]> dgit.raspbian.org Git - gnome-shell.git/commit
portalHelper: Schedule recheck if it's too soon to recheck
authorMichael Catanzaro <mcatanzaro@redhat.com>
Sun, 27 Jul 2025 14:40:51 +0000 (16:40 +0200)
committerMarge Bot <marge-bot@gnome.org>
Sun, 3 Aug 2025 19:15:27 +0000 (19:15 +0000)
commitf9c41ea665dc0dd175ba5933c867c4551c4acf95
treee9b8a95a36def438b484feb423438773b2b60381
parent387911c5154fcd86b98c103ddaa365e1aa563e48
portalHelper: Schedule recheck if it's too soon to recheck

Currently we have a 30 second limit on rechecks. A recheck that would
violate the limit is simply dropped. This causes the portal helper to
never close itself.

Instead, schedule a future recheck for as soon as the timeout expires.
This will put an upper bound on how long the portal helper will
unnecessarily remain open.

(I've also changed the logic to unconditionally emit CANCELLED in
vfunc_close_request(), since this seems more correct. This won't
actually affect anything, because gnome-shell just ignores the
CANCELLED status, but in theory it's nice to end things with an
indication that we are finished. Otherwise, CANCELLED will never be
emitted.)

Closes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7790

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3813>
js/portalHelper/main.js